-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Chrome 144 RTCDegradationPreference maintain-framerate-and-resolution… #28898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Chrome 144 RTCDegradationPreference maintain-framerate-and-resolution… #28898
Conversation
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
api/RTCRtpSender.json
Outdated
| "deprecated": false | ||
| } | ||
| }, | ||
| "maintain-framerate-and-resolution_value": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see how it could be useful if we captured this level of detail (what values a property in the returned object can take), but ultimately I don't think it makes sense for the getter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, fair enough. I've removed this sub-data point from the getter.
| "deprecated": false | ||
| } | ||
| }, | ||
| "maintain-framerate-and-resolution_value": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean the other three values are not supported?
"maintain-framerate""maintain-resolution""balanced"
If some of these are also supported (possibly in an earlier version), we should add them as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other values have been supported since the property was first implemented. In my experience, people tend to assume that API data where you only list the property and not all of its values separately means that all the values are supported, not none of the values are supported. So we tend to only list separate sub-points for values that started to be supported later.
… value
Summary
Chrome 144 adds support for the
maintain-framerate-and-resolutionvalue of theRTCDegradationPreferencedictionary, which is used in the options object of theRTCRtpSender.setParameters()method, and available in the return value of theRTCRtpSender.getParameters()method.See https://chromestatus.com/feature/5156290162720768 for the release details.
This PR adds a sub-data point to each method's data structure for this new value.
Test results and supporting details
Related issues