Skip to content

Fixes bug in Django logout code #33385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2024
Merged

Fixes bug in Django logout code #33385

merged 1 commit into from
May 3, 2024

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented May 3, 2024 •
edited
Loading

Fixes #33287

This was directing to wrong URL.

Fix to demo project in mdn/django-locallibrary-tutorial#144

@hamishwillee hamishwillee requested a review from a team as a code owner May 3, 2024 02:27
@hamishwillee hamishwillee requested review from teoli2003 and removed request for a team May 3, 2024 02:27
@github-actions github-actions bot added the Content:Learn:Django Learning area Django docs label May 3, 2024
@hamishwillee hamishwillee mentioned this pull request May 3, 2024
Merged
@github-actions github-actions bot added the size/xs [PR only] 0-5 LoC changed label May 3, 2024
@hamishwillee hamishwillee mentioned this pull request May 3, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024 •
edited
Loading

Preview URLs

(comment last updated: 2024-05-03 08:21:37)

@hamishwillee hamishwillee mentioned this pull request May 3, 2024
Closed
4 tasks
@bsmth bsmth reopened this May 3, 2024
bsmth
bsmth approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(auto-closed when I merged the other PR) Looks good, TY

@bsmth bsmth merged commit 77f862c into mdn:main May 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth bsmth approved these changes

@teoli2003 teoli2003 Awaiting requested review from teoli2003 teoli2003 was automatically assigned from mdn/yari-content-http

Assignees
No one assigned
Labels
Content:Learn:Django Learning area Django docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Log out only working for superuser, other users throw "Django administration" authorization error on logout
2 participants
@hamishwillee @bsmth