Django Tute: session count matches what is displayed #35423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of num_visits in the Django tute was being fetched from session variable, updated, saved, and then displaying the last stored value. This was intentional, displaying "the number of visits you have done before this one". It is however not how most/many people would interpret the text ("what number visit is this to the page").
This changes the meaning to the second case, by making sure that what is stored in the variable and what is displayed matches.
This is the English fix to mdn/translated-content#23260
Associated demo code fix in mdn/django-locallibrary-tutorial#148
This will need to be pushed to the translation.