Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add links for svg presentation attributes #37614

Merged
merged 6 commits into from
Feb 4, 2025
Merged

Add links for svg presentation attributes #37614

merged 6 commits into from
Feb 4, 2025

Conversation

skyclouds2001
Copy link
Contributor

Description

Add links for svg presentation attributes

for svg attributes, add link to the css property if possible
for css properties, add link to the svg attribute if possible

Motivation

Additional details

Related issues and pull requests

@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:SVG SVG docs size/m [PR only] 51-500 LoC changed labels Jan 12, 2025
@skyclouds2001 skyclouds2001 marked this pull request as ready for review January 12, 2025 08:08
@skyclouds2001 skyclouds2001 requested review from a team as code owners January 12, 2025 08:08
@skyclouds2001 skyclouds2001 requested review from estelle and hamishwillee and removed request for a team January 12, 2025 08:08
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 12, 2025 •
edited
Loading

Preview URLs (82 pages)
Flaws (21)

Note! 74 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/height
Title: height
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/intrinsic-size-keyword

URL: /en-US/docs/Web/CSS/clip-path
Title: clip-path
Flaw count: 4

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
    • Can't resolve /en-US/docs/Web/CSS/url-token
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
  • macros:
    • Macro produces link /en-US/docs/Web/CSS/url which is a redirect

URL: /en-US/docs/Web/CSS/mask
Title: mask
Flaw count: 4

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
    • Can't resolve /en-US/docs/Web/CSS/url-token
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
  • macros:
    • Macro produces link /en-US/docs/Web/CSS/url which is a redirect

URL: /en-US/docs/Web/CSS/width
Title: width
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/intrinsic-size-keyword

URL: /en-US/docs/Web/CSS/filter
Title: filter
Flaw count: 4

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/zero
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
    • Can't resolve /en-US/docs/Web/CSS/url-token
    • Can't resolve /en-US/docs/Web/CSS/url-modifier

URL: /en-US/docs/Web/CSS/word-spacing
Title: word-spacing
Flaw count: 1

  • macros:
    • Can't resolve /en-US/docs/Web/SVG/Attribute/word-spacin

URL: /en-US/docs/Web/CSS/cursor
Title: cursor
Flaw count: 5

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/url-set
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
    • Can't resolve /en-US/docs/Web/CSS/url-token
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
  • macros:
    • Macro produces link /en-US/docs/Web/CSS/url which is a redirect

URL: /en-US/docs/Web/SVG/Attribute/direction
Title: direction
Flaw count: 1

  • macros:
    • Can't resolve /en-US/docs/Web/SVG/Attribute/inline-size
External URLs (1)

URL: /en-US/docs/Web/CSS/writing-mode
Title: writing-mode

(comment last updated: 2025-02-04 21:52:56)

estelle
estelle requested changes Jan 14, 2025
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding these links.
For CSS properties that apply to all or almost all elements -- in other word, CSS properties that are not SVG-element specific -- please include the SVG attribute link AFTER the links pointing to other pages within the CSS section.

@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Jan 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Jan 27, 2025
@hamishwillee hamishwillee removed their request for review January 28, 2025 06:29
@skyclouds2001 skyclouds2001 requested a review from estelle February 4, 2025 13:44
estelle
estelle approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! 🎉

@estelle estelle merged commit 64d85b7 into mdn:main Feb 4, 2025
8 checks passed
@skyclouds2001 skyclouds2001 deleted the svg-presentation branch February 5, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:SVG SVG docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skyclouds2001 @estelle @bsmth