Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug-1659500 contextualIdentities API undefined in Firefox for Android #38427

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rebloor
Copy link
Contributor

@rebloor rebloor commented Mar 3, 2025

Description

Addresses the dev-docs-needed requirements for Bug 1659500 "Disable contextualIdentities API until GeckoView's container feature is implemented correctly" by adding a release note.

Related issues and pull requests

Note added to the BCD in mdn/browser-compat-data#26097

@rebloor rebloor added the Content:WebExt WebExtensions docs label Mar 3, 2025
@rebloor rebloor requested review from dotproto and Rob--W March 3, 2025 15:55
@rebloor rebloor self-assigned this Mar 3, 2025
@rebloor rebloor requested a review from a team as a code owner March 3, 2025 15:55
@rebloor rebloor requested review from bsmth and removed request for a team March 3, 2025 15:55
@github-actions github-actions bot added Content:Firefox Content in the Mozilla/Firefox subtree and removed Content:WebExt WebExtensions docs labels Mar 3, 2025
@github-actions github-actions bot added the size/m [PR only] 51-500 LoC changed label Mar 3, 2025
Copy link
Contributor

github-actions bot commented Mar 3, 2025

Preview URLs

External URLs (1)

URL: /en-US/docs/Mozilla/Firefox/Releases/138
Title: Firefox 138 for developers

(comment last updated: 2025-03-06 15:51:00)

@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Mar 5, 2025
Copy link
Contributor

github-actions bot commented Mar 5, 2025

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added size/xs [PR only] 0-5 LoC changed and removed merge conflicts 🚧 [PR only] size/m [PR only] 51-500 LoC changed labels Mar 5, 2025
@@ -58,6 +58,8 @@ This article provides information about the changes in Firefox 138 that affect d

## Changes for add-on developers

- The {{WebExtAPIRef("contextualIdentities")}} API is no longer defined in Firefox for Android. Previously, it was defined but not functional. ([Firefox bug 1659500](https://bugzil.la/1659500))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just dropping by after merging in main -> should this be under Removals?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsmth I wanted to avoid any connotation that we were removing contextual identities. This is more a case of hiding it until the implementation works as it should.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A side effect of this change is that it is no longer possible for extensions to activate the container tab functionality on Firefox for Android. This was also tied to the "contextualIdentities" permission, but not correctly implemented.

^ the above additional context is also mentioned in the bug.

Copy link
Contributor Author

@rebloor rebloor Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rob--W could you please clarify? As you note, the permission is mentioned in the bug, but there's no specific information, that I can see, as to what changes may have been made. It would seem that we've always marked the permission as supported (from Firefox for Android 53) and always marked the API as unsupported, with its note about the API being accessible but not functional. Should the permission be amended to indicate that it was never supported or that it was withdrawn in 138? Or is it still supported, but has no effect from 138 (which is what I assume from the bug info)

Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the additional note before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants