-
Notifications
You must be signed in to change notification settings - Fork 22.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug-1659500 contextualIdentities API undefined in Firefox for Android #38427
base: main
Are you sure you want to change the base?
Bug-1659500 contextualIdentities API undefined in Firefox for Android #38427
Conversation
Preview URLs External URLs (1)URL:
(comment last updated: 2025-03-06 15:51:00) |
This pull request has merge conflicts that must be resolved before it can be merged. |
…ed-in-Firefox-for-Android-
@@ -58,6 +58,8 @@ This article provides information about the changes in Firefox 138 that affect d | |||
|
|||
## Changes for add-on developers | |||
|
|||
- The {{WebExtAPIRef("contextualIdentities")}} API is no longer defined in Firefox for Android. Previously, it was defined but not functional. ([Firefox bug 1659500](https://bugzil.la/1659500)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just dropping by after merging in main -> should this be under Removals?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsmth I wanted to avoid any connotation that we were removing contextual identities. This is more a case of hiding it until the implementation works as it should.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A side effect of this change is that it is no longer possible for extensions to activate the container tab functionality on Firefox for Android. This was also tied to the "contextualIdentities" permission, but not correctly implemented.
^ the above additional context is also mentioned in the bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rob--W could you please clarify? As you note, the permission is mentioned in the bug, but there's no specific information, that I can see, as to what changes may have been made. It would seem that we've always marked the permission as supported (from Firefox for Android 53) and always marked the API as unsupported, with its note about the API being accessible but not functional. Should the permission be amended to indicate that it was never supported or that it was withdrawn in 138? Or is it still supported, but has no effect from 138 (which is what I assume from the bug info)
…ed-in-Firefox-for-Android-
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add the additional note before merging.
Description
Addresses the dev-docs-needed requirements for Bug 1659500 "Disable contextualIdentities API until GeckoView's container feature is implemented correctly" by adding a release note.
Related issues and pull requests
Note added to the BCD in mdn/browser-compat-data#26097