-
Notifications
You must be signed in to change notification settings - Fork 22.9k
Update Firefox 145 release notes for WebDriver conforming changes #41806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
c59efc1 to
3d141e9
Compare
|
Preview URLs Flaws (4)URL:
External URLs (7)URL:
(comment last updated: 2025-11-04 22:47:51) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Julian. Just some comments from my side.
| <!-- #### WebDriver BiDi --> | ||
|
|
||
| <!-- #### Marionette --> | ||
| - Implemented the "emulation.setUserAgentOverride" command, which allows to override the user-agent string used by the browser either for a set of contexts, user contexts or globally. ([Firefox bug 1987935](https://bugzil.la/1987935)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the following for all the bullet points:
| - Implemented the "emulation.setUserAgentOverride" command, which allows to override the user-agent string used by the browser either for a set of contexts, user contexts or globally. ([Firefox bug 1987935](https://bugzil.la/1987935)) | |
| - Implemented the `emulation.setUserAgentOverride` command, which allows to override the user-agent string used by the browser either for a set of contexts, user contexts or globally. ([Firefox bug 1987935](https://bugzil.la/1987935)). |
| - Updated the "destination" property of the "network.beforeRequestSent" event to "document" for top-level navigations. ([Firefox bug 1985552](https://bugzil.la/1985552)) | ||
| - Fixed a bug for network data collection, where non-ASCII characters in response bodies were not properly encoded. ([Firefox bug 1986022](https://bugzil.la/1986022)) | ||
| - Fixed a bug with the "network.getData" command, which would fail requests with an empty response body. ([Firefox bug 1986025](https://bugzil.la/1986025)) | ||
| - Updated the "browsingContext" download events to reuse the same navigation id as the previous browsingContext.navigationStarted event. ([Firefox bug 1986938](https://bugzil.la/1986938)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't that only necessary for the started event given that the implementation of dowload end had it immediately included?
Otherwise a nit:
| - Updated the "browsingContext" download events to reuse the same navigation id as the previous browsingContext.navigationStarted event. ([Firefox bug 1986938](https://bugzil.la/1986938)) | |
| - Updated the "browsingContext" download events to reuse the same navigation id as the previous `browsingContext.navigationStarted` event. ([Firefox bug 1986938](https://bugzil.la/1986938)) |
Release notes update based on the following list of relnote worthy bugs.