Better error handling for WebGPU feature testing #42647
Open
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added error handling for requestAdapter example call.
jespertheend
requested review from
sideshowbarker
and removed request for
a team
github-actions
bot
added
Content:WebAPI
Contributor
|
Preview URLs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added error handling for requestAdapter example call.
Motivation
See https://bugzilla.mozilla.org/show_bug.cgi?id=2008734
Firefox seems to throw during the
navigator.gpu.requestAdapter()call when WebGPU is disabled by a blocklist, so I think it's better to be explicitly demonstrate this behaviour here. We used this snippet to feature test webgpu support and fallback to webgl if it wasn't supported, so this change in Firefox broke some of our sites.Additional details
Related issues and pull requests