Fix: clarify cross-site terminology and SameSite=Lax behavior #42947
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrealungh1
requested review from
hamishwillee
and removed request for
a team
github-actions
bot
added
Content:Security
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clarifies the
SameSitecookie attribute documentation by replacing incorrect cross-origin terminology with cross-site and by making the description ofSameSite=Laxmore precise.Motivation
The SameSite attribute is defined in terms of site (scheme + eTLD+1), not origin. Using cross-origin terminology can mislead readers and make it harder to understand real browser behavior.
Additionally, while the existing description of
SameSite=Laxwas technically correct, it was imprecise. This update clarifies when cookies are included or omitted by explicitly distinguishing top-level navigations from subresource requests and safe HTTP methods from state-changing ones.Additional details
Related issues and pull requests
Fixes #42945