-
Notifications
You must be signed in to change notification settings - Fork 23.1k
reorder CSS layout test your skills for consistency #42953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
reorder CSS layout test your skills for consistency #42953
Conversation
dipikabh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chrisdavidmills.
That's a good strategy to avoid confusion and makes better sense - adding the starting point rendering before the expected output. I have a small suggestion to reorder the frames within the starting blocks: show the rendered iframe first and then the corresponding code snippets.
I've also left a few small edits in nearby text.
Leaving a +1
|
|
||
| {{EmbedLiveSample("flexbox1-start", "", "240px")}} | ||
|
|
||
| The finished task should look like this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about:
| The finished task should look like this: | |
| When the task is complete, the items should look like this: |
|
|
||
| {{EmbedLiveSample("flexbox1-finish", "", "100px")}} | ||
|
|
||
| ```html live-sample___flexbox1-start live-sample___flexbox1-finish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an exception to the order we usually follow on other content pages, in the test your skills sections, should we have the resultant frame of the starting point first with "The starting point of this task looks like this:" followed by the HTML and CSS snippets with something like "Here's the underlying code for this starting point:"
| ``` | ||
|
|
||
| This is the starting state of the task: | ||
| The starting point of the task looks like this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The starting point of the task looks like this: | |
| The starting point of this task looks like this: |
| ``` | ||
|
|
||
| This is the starting state of the task: | ||
| The starting point of the task looks like this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar edits and ordering suggestion for this one
| @@ -88,10 +88,6 @@ nav ul { | |||
|
|
|||
| In this task, the list items are all different sizes, but we want them to be displayed as three equal-sized columns, no matter what content is in each item. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| In this task, the list items are all different sizes, but we want them to be displayed as three equal-sized columns, no matter what content is in each item. | |
| In this task, the list items are all different sizes, but we want them to be displayed as three equal-sized columns, no matter the content in each item. |
| In this task, you will need to use both grid layout and flexbox to recreate the example as seen in the finished rendering below. The gap between the column and row tracks should be 10px. You do not need to make any changes to the HTML in order to achieve this. | ||
|
|
||
| {{EmbedLiveSample("grid4-finish", "", "400px")}} | ||
| In this task, you will need to use both grid layout and flexbox to recreate the finished layout. The gap between the column and row tracks should be 10px. You do not need to make any changes to the HTML in order to achieve this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| In this task, you will need to use both grid layout and flexbox to recreate the finished layout. The gap between the column and row tracks should be 10px. You do not need to make any changes to the HTML in order to achieve this. | |
| In this task, you will need to use both grid layout and flexbox to recreate the finished layout. The gap between the column and row tracks should be `10px`. You do not need to make any changes to the HTML in order to achieve this. |
|
|
||
| {{EmbedLiveSample("position1-finish", "", "250px")}} | ||
|
|
||
| **Bonus question:** Can you change the target to display underneath the text? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| **Bonus question:** Can you change the target to display underneath the text? | |
| **Bonus question:** Can you change the target so it displays underneath the text? |
| @@ -17,10 +17,6 @@ The aim of this skill test is to help you assess whether you understand [positio | |||
|
|
|||
| To complete this task, position the item with a class of `target` to the top and right of the container, which has the 5px grey border. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| To complete this task, position the item with a class of `target` to the top and right of the container, which has the 5px grey border. | |
| To complete this task, position the element with the `target` class at the top-right corner of the container that has a `5px` gray border. |
|
|
||
| {{EmbedLiveSample("position1-start", "", "400px")}} | ||
|
|
||
| The finished task should look like this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The finished task should look like this: | |
| When you complete this task, the placement of the target should look like this: |
|
|
||
| {{EmbedLiveSample("position2-start", "", "400px")}} | ||
|
|
||
| The finished task should look like this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The finished task should look like this: | |
| The finished layout should look like this: |
Description
I got some feedback that the ordering of the "Test your skills" articles has become confusing since the last update. Specifically, in some of the tests, the "solution" live sample appears before the "starting state" live sample, so it is unclear which one to click on to start the test.
To remedy this, I have decided to go through all the "Test your skills" articles and make the structure as consistent as possible throughout, fixing the above issue in the process.
This PR in particular updates the structure of the CSS layout "Test your skills" articles.
Note: Not all of the tests show the finished state of the example. I have elected not to show it in cases where the before and after rendering look no different, where the final rendering gives away the answer, and where the question is freeform so there is no single answer.
Motivation
Additional details
Related issues and pull requests