Skip to content

Conversation

@chrisdavidmills
Copy link
Contributor

Description

I got some feedback that the ordering of the "Test your skills" articles has become confusing since the last update. Specifically, in some of the tests, the "solution" live sample appears before the "starting state" live sample, so it is unclear which one to click on to start the test.

To remedy this, I have decided to go through all the "Test your skills" articles and make the structure as consistent as possible throughout, fixing the above issue in the process.

This PR in particular updates the structure of the CSS layout "Test your skills" articles.

Note: Not all of the tests show the finished state of the example. I have elected not to show it in cases where the before and after rendering look no different, where the final rendering gives away the answer, and where the question is freeform so there is no single answer.

Motivation

Additional details

Related issues and pull requests

@chrisdavidmills chrisdavidmills requested a review from a team as a code owner January 28, 2026 16:51
@chrisdavidmills chrisdavidmills requested review from hamishwillee and removed request for a team January 28, 2026 16:51
@github-actions github-actions bot added Content:Learn Learning area docs size/m [PR only] 51-500 LoC changed labels Jan 28, 2026
@github-actions
Copy link
Contributor

Preview URLs (4 pages)

Flaws (4)

Found an unexpected or unresolvable flaw? Please report it here.

URL: /en-US/docs/Learn_web_development/Core/CSS_layout/Test_your_skills/Flexbox
Title: Test your skills: Flexbox
Flaw count: 1

  • macros:
    • Macro ? produces link /en-US/curriculum/ which doesn't resolve

URL: /en-US/docs/Learn_web_development/Core/CSS_layout/Test_your_skills/Floats
Title: Test your skills: Floats
Flaw count: 1

  • macros:
    • Macro ? produces link /en-US/curriculum/ which doesn't resolve

URL: /en-US/docs/Learn_web_development/Core/CSS_layout/Test_your_skills/Grid
Title: Test your skills: CSS grids
Flaw count: 1

  • macros:
    • Macro ? produces link /en-US/curriculum/ which doesn't resolve

URL: /en-US/docs/Learn_web_development/Core/CSS_layout/Test_your_skills/Position
Title: Test your skills: Positioning
Flaw count: 1

  • macros:
    • Macro ? produces link /en-US/curriculum/ which doesn't resolve

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chrisdavidmills.
That's a good strategy to avoid confusion and makes better sense - adding the starting point rendering before the expected output. I have a small suggestion to reorder the frames within the starting blocks: show the rendered iframe first and then the corresponding code snippets.
I've also left a few small edits in nearby text.

Leaving a +1


{{EmbedLiveSample("flexbox1-start", "", "240px")}}

The finished task should look like this:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about:

Suggested change
The finished task should look like this:
When the task is complete, the items should look like this:


{{EmbedLiveSample("flexbox1-finish", "", "100px")}}

```html live-sample___flexbox1-start live-sample___flexbox1-finish
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an exception to the order we usually follow on other content pages, in the test your skills sections, should we have the resultant frame of the starting point first with "The starting point of this task looks like this:" followed by the HTML and CSS snippets with something like "Here's the underlying code for this starting point:"

```

This is the starting state of the task:
The starting point of the task looks like this:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The starting point of the task looks like this:
The starting point of this task looks like this:

```

This is the starting state of the task:
The starting point of the task looks like this:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar edits and ordering suggestion for this one

@@ -88,10 +88,6 @@ nav ul {

In this task, the list items are all different sizes, but we want them to be displayed as three equal-sized columns, no matter what content is in each item.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In this task, the list items are all different sizes, but we want them to be displayed as three equal-sized columns, no matter what content is in each item.
In this task, the list items are all different sizes, but we want them to be displayed as three equal-sized columns, no matter the content in each item.

In this task, you will need to use both grid layout and flexbox to recreate the example as seen in the finished rendering below. The gap between the column and row tracks should be 10px. You do not need to make any changes to the HTML in order to achieve this.

{{EmbedLiveSample("grid4-finish", "", "400px")}}
In this task, you will need to use both grid layout and flexbox to recreate the finished layout. The gap between the column and row tracks should be 10px. You do not need to make any changes to the HTML in order to achieve this.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In this task, you will need to use both grid layout and flexbox to recreate the finished layout. The gap between the column and row tracks should be 10px. You do not need to make any changes to the HTML in order to achieve this.
In this task, you will need to use both grid layout and flexbox to recreate the finished layout. The gap between the column and row tracks should be `10px`. You do not need to make any changes to the HTML in order to achieve this.


{{EmbedLiveSample("position1-finish", "", "250px")}}

**Bonus question:** Can you change the target to display underneath the text?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Bonus question:** Can you change the target to display underneath the text?
**Bonus question:** Can you change the target so it displays underneath the text?

@@ -17,10 +17,6 @@ The aim of this skill test is to help you assess whether you understand [positio

To complete this task, position the item with a class of `target` to the top and right of the container, which has the 5px grey border.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To complete this task, position the item with a class of `target` to the top and right of the container, which has the 5px grey border.
To complete this task, position the element with the `target` class at the top-right corner of the container that has a `5px` gray border.


{{EmbedLiveSample("position1-start", "", "400px")}}

The finished task should look like this:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The finished task should look like this:
When you complete this task, the placement of the target should look like this:


{{EmbedLiveSample("position2-start", "", "400px")}}

The finished task should look like this:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The finished task should look like this:
The finished layout should look like this:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:Learn Learning area docs size/m [PR only] 51-500 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants