List all OscillatorNode waveform types in Web Audio API overview#43935
Open
List all OscillatorNode waveform types in Web Audio API overview#43935
Conversation
github-actions
Bot
added
Content:WebAPI
Contributor
|
Preview URLs (1 page) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current text reads "represents a periodic waveform, such as a sine or triangle wave," giving readers only two of the five supported shapes. Listing the full set (sine, square, sawtooth, triangle, custom) matches the OscillatorNode.type page and gives readers unfamiliar with waveform names a better chance of recognizing one.
Motivation
Replaced "such as" with an em dash since the list is now complete rather than illustrative. Recognizing even one of the listed shapes can help readers anchor the rest of the description.
Additional details
Reference: OscillatorNode.type
Related issues and pull requests
Fixes #43925