chore(css): Update group field for css selectors - #965
Merged
Conversation
skyclouds2001
marked this pull request as ready for review
April 3, 2025 18:27
skyclouds2001
requested review from
a team and
bsmth
and removed request for
a team
April 3, 2025 18:27
bsmth
reviewed
Apr 7, 2025
| @@ -146,25 +130,20 @@ | |||
| ":active-view-transition": { | |||
Member
There was a problem hiding this comment.
Commenting for traceability: https://www.w3.org/TR/css-view-transitions-2/#the-active-view-transition-pseudo
Member
|
Thanks a lot. In general, this is technically correct, so I would be curious to get another opinion again on whether:
is what consumers expect as opposed to these returned when someone is looking for a list of pseudo-classes or pseudo-elements. "Defined in" versus "can be classed as" is a good distinction to double-check. |
github-actions
Bot
added
the
idle
bsmth
self-requested a review
August 25, 2025 09:03
github-actions
Bot
removed
the
idle
bsmth
approved these changes
Sep 25, 2025
bsmth
left a comment
bsmth
left a comment
Member
There was a problem hiding this comment.
I think this is good. @pepelsbey do you agree?
pepelsbey
approved these changes
Sep 30, 2025
pepelsbey
left a comment
pepelsbey
left a comment
Member
There was a problem hiding this comment.
Yep, makes sense to me! Thank you :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
to make the group field really represents which module the feature is defined
Motivation
Additional details
Related issues and pull requests