Skip to content

fix(deployer): decrease chunk size #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LeoMcA merged 2 commits into from
Apr 28, 2026
+2 −2
Merged

fix(deployer): decrease chunk size #317

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1858a4
fix(deployer): decrease chunk size
LeoMcA Apr 28, 2026
bf27c09
decrease max_chunk_bytes too
LeoMcA Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deployer/src/deployer/search/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def get_progressbar():
for success, info in streaming_bulk(
connection,
generator(),
chunk_size=250, # default: 500
chunk_size=125, # default: 500
max_chunk_bytes=52428800, # default: 104857600
Copy link
Copy Markdown
Contributor

@caugner caugner Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Shouldn't we also decrease max_chunk_bytes?

Copy link
Copy Markdown
Member Author

@LeoMcA LeoMcA Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, indeed: it's the min of either

max_retries=4, # default: 0
# If the bulk indexing failed, it will by default raise a BulkIndexError.
Expand Down
Loading