refactor(cloud-function): extract REVIEW_ROUTING + CACHE_DISABLED#320
Open
refactor(cloud-function): extract REVIEW_ROUTING + CACHE_DISABLED#320
Conversation
Replaces the `WILDCARD_ENABLED` environment variable.
LeoMcA
reviewed
May 1, 2026
| const response = await fetch(`${target}${locale}/404/index.html`); | ||
| notFoundBuffer = response.arrayBuffer(); | ||
| if (!WILDCARD_ENABLED) { | ||
| if (!CACHE_DISABLED) { |
Member
There was a problem hiding this comment.
This feels more like REVIEW_ROUTING rather than CACHE_DISABLED: we are disabling a cache, but it's not anything to do with the cache-control header.
Suggested change
| if (!CACHE_DISABLED) { | |
| if (!REVIEW_ROUTING) { |
Presumably we do this to allow some aspect of review routing to work, and don't need to enable it independently?
| - `REVIEW_ROUTING` (default: `false`) - If enabled, accepts any `Host` header | ||
| value, uses the leftmost subdomain to route into a subdirectory of | ||
| `SOURCE_CONTENT`, and falls back to production for missing assets. | ||
| - `CACHE_DISABLED` (default: `false`) - If enabled, disables response caching |
Member
There was a problem hiding this comment.
Needs updating if the above change is accepted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the
WILDCARD_ENABLEDenvironment variable by two variablesREVIEW_ROUTINGandCACHE_DISABLED.Motivation
Make the environment variable names clearer, and separate the two purposes.
Additional details
Related issues and pull requests
Fixes #200.