Skip to content

ci(build): enable GA for Fred #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caugner merged 1 commit into from
Oct 14, 2025
Merged

ci(build): enable GA for Fred #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/prod-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,8 @@ jobs:
# - developer.mozilla.org (GA4)
# Using measurement ids on other domains is okay, as GA will filter these events.
BUILD_GOOGLE_ANALYTICS_MEASUREMENT_ID: G-PWTK27XVWP
Copy link
Copy Markdown
Member

@LeoMcA LeoMcA Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seemed to be the yari env var, shouldn't be needed any more:

Suggested change
BUILD_GOOGLE_ANALYTICS_MEASUREMENT_ID: G-PWTK27XVWP

Copy link
Copy Markdown
Contributor Author

@caugner caugner Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need it for MDN Plus.

FRED_GA_ENABLED: true
FRED_GA_MEASUREMENT_ID: G-PWTK27XVWP

# This enables the MDN Plus
REACT_APP_ENABLE_PLUS: true
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/stage-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,8 @@ jobs:
# - developer.allizom.org (GA4)
# Using measurement ids on other domains is okay, as GA will filter these events.
BUILD_GOOGLE_ANALYTICS_MEASUREMENT_ID: G-ZG5HNVZRY0
Copy link
Copy Markdown
Member

@LeoMcA LeoMcA Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
BUILD_GOOGLE_ANALYTICS_MEASUREMENT_ID: G-ZG5HNVZRY0

Copy link
Copy Markdown
Contributor Author

@caugner caugner Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need it for MDN Plus.

FRED_GA_ENABLED: true
FRED_GA_MEASUREMENT_ID: G-ZG5HNVZRY0

# This enables the Plus call-to-action banner and the Plus landing page
REACT_APP_ENABLE_PLUS: true
Expand Down