fix(cloud-function): pull libs in to replace file: dependencies#72
Merged
fix(cloud-function): pull libs in to replace file: dependencies#72
libs in to replace file: dependencies#72Conversation
LeoMcA
approved these changes
Oct 24, 2025
Member
LeoMcA
left a comment
LeoMcA
left a comment
There was a problem hiding this comment.
Nice stuff, getting rid of all these package.jsons is a big win: I always found it confusing. Ignore my typescript comment, it'll be trivial to convert the few changes here to typescript-in-jsdoc in the future.
caugner
force-pushed
the
move-libs-into-cloud-function
branch
from
b48499b to
9ba1946
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
caugner
force-pushed
the
move-libs-into-cloud-function
branch
from
9ba1946 to
fd8fcf5
Compare
caugner
force-pushed
the
move-libs-into-cloud-function
branch
from
b876190 to
7f08608
Compare
Contributor
Author
|
Checked on the test environment, and everything seems to be working, including Playground and Ads. |
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move
/libsrequired by the Cloud Function into/cloud-function/src/internal.Note: Also moves
/markdowninto/libs, for consistency.Motivation
Unblocks Dependabot, which currently cannot update Cloud Function dependencies.
Additional details
Related issues and pull requests
Test deployment: https://github.com/mdn/dex/actions/runs/18776919020