test(scanner): use fixtures to test [observatory.]mozilla.org #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
changed the title
caugner
force-pushed
the
update-test-expectatios
branch
from
874753b to
6731178
Compare
caugner
force-pushed
the
update-test-expectatios
branch
from
6731178 to
cd807c0
Compare
LeoMcA
approved these changes
Jan 15, 2026
Member
LeoMcA
left a comment
LeoMcA
left a comment
There was a problem hiding this comment.
Mostly looks good: there's a linting issue, and I'd drop all scanning/storing of scan results in the fixture capturing.
It would be great to use https://undici.nodejs.org/#/docs/api/SnapshotAgent.md to entirely mock the requests/responses, but there were some issues with that when I tried to use it in the MCP server, which I have a half-baked PR locally to fix. It may be possible to use it this way, with a clear capture step: I was attempting to get it to auto-update any fixtures on disk which were missing. But the approach in this PR works, so no need to spend extra time to see if a different approach works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the test expecations for mozilla.org.
Motivation
Test started failing, because the score for mozilla.org changed.
Additional details
Related issues and pull requests