DAFunction- viscous dissipation added - #1001
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (3.22%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1001 +/- ##
==========================================
- Coverage 77.62% 77.49% -0.13%
==========================================
Files 321 323 +2
Lines 17793 17824 +31
==========================================
+ Hits 13811 13812 +1
- Misses 3982 4012 +30 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@Ananth-Narayan-IITM , the cpp_format test failed, check: https://github.com/mdolab/dafoam/actions/runs/28873032017/job/85891037232?pr=1001 Please use the Clang_format to reformat the .H and .C codes you added. Also, please add a simple regression test to this test file: https://github.com/mdolab/dafoam/blob/main/tests/runUnitTests_DAFunction.py. Basically, we need to make sure all newly added codes are run in the reg_tests. |
Purpose
For most of the topology optimization, viscous dissipation will be used as objective function which is to be minimized. Thus, added subclass-
DAFunctionViscousDissipationunder the classDAFunctionsuch that users can utilize/ update this functionType of change
This is addition to DAFunction class
For details on viscous dissipation, refer Olesen2005
Testing
The code is verified and working fine. However, needs verification which is ongoing. Shall update in case of any changes
Checklist
Put an
xin the boxes that apply.Please let me know in case of addition details.