Skip to content

Remove the type casting of JSX runtimes #2604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025
Merged

Conversation

remcohaszing
Copy link
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and discussions and couldn’t find anything or linked relevant results below
  • I made sure the docs are up to date
  • I included tests (or that’s not needed)

Description of changes

There used to be type incompatibilities for JSX runtimes. This isn’t the case anymore. This removes the now redundant type casting from tests and a warning from the docs.

It used to cause errors. Now it doesn’t anymore.
@remcohaszing remcohaszing added 🦋 type/enhancement This is great to have 🕸️ area/tests This affects tests 👶 semver/patch This is a backwards-compatible fix 🕸 area/website This affects the website 🤞 phase/open Post is being triaged manually labels Apr 2, 2025
Copy link

vercel bot commented Apr 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mdx ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 7:18pm

@wooorm wooorm merged commit 67fb1d0 into main Apr 3, 2025
16 checks passed
@wooorm wooorm deleted the remove-jsx-runtime-typecasting branch April 3, 2025 12:48

This comment has been minimized.

@wooorm wooorm added the 💪 phase/solved Post is done label Apr 3, 2025
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕸️ area/tests This affects tests 🕸 area/website This affects the website 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🦋 type/enhancement This is great to have
Development

Successfully merging this pull request may close these issues.

3 participants