-
Notifications
You must be signed in to change notification settings - Fork 52
add 1155CM #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TaoGe96
wants to merge
21
commits into
me-foundation:main
Choose a base branch
from
TaoGe96:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add 1155CM #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # cli-typescript/src/utils/getters.ts
# Conflicts: # cli-typescript/src/utils/getters.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for ERC1155C for MagicDrop.
This is a temporary solution targeting L2 deployments, as the contract code size exceeds 24KB, making it undeployable on Ethereum mainnet.
Due to this limitation, we cannot directly inherit from ERC1155M. Instead, most of the implementation is copied from ERC1155MInitializable v1.0.2, with minimal modifications.
The reason for this approach is that some functions in ERC1155MInitializable, such as:
are not declared as virtual, and therefore cannot be overridden, which prevents us from extending the contract via inheritance.
test on monad