ts-cli support 1.0.2 contract #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhirst
reviewed
Dec 9, 2025
| mintCurrency as Hex, | ||
| fundReceiver as Hex, | ||
| parsedStagesData, | ||
| parsedStagesData as any, |
Contributor
There was a problem hiding this comment.
Why do we need to cast here? Should we check the stages data with a typeguard instead?
Contributor
Author
There was a problem hiding this comment.
it's union type and ts can not recognize both, now separated into 2 types
tomhirst
reviewed
Dec 9, 2025
| 'function setup(string,uint256[],uint256[],address,address,(uint80[],uint80[],uint32[],bytes32[],uint24[],uint256,uint256)[],address,uint96)'; | ||
| // Choose setup signature based on version | ||
| const setupSignature = isLegacy | ||
| ? 'function setup(string,uint256[],uint256[],address,address,(uint80[],uint80[],uint32[],bytes32[],uint24[],uint256,uint256)[],address,uint96)' |
Contributor
There was a problem hiding this comment.
Let's put these in constants. LEGACY_SETUP_SIGNATURE / SETUP_SIGNATURE — will be easier to read.
cli-typescript/src/utils/getters.ts
Outdated
| import { monad } from '../cmds/networks'; | ||
| import { defineChain } from 'viem'; | ||
|
|
||
| export const monad = defineChain({ |
Contributor
There was a problem hiding this comment.
Is Monad not in the latest version if viem already?
tomhirst
approved these changes
Dec 10, 2025
tenthirtyone
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deploy 721c on monad
https://monadvision.com/address/0x5993cd99e21113d743318ce64fe20c7b6f53e88c?tab=Contract
set mint fee
get mint fee
set stages new abi
deploy and setup 721 on base
set stages for legacy abi (base)
