feat: setting to hide password login #4943
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/docs/documentation/getting-started/installation/backend-config.md
Outdated
Show resolved
Hide resolved
|
Generally looks good. I want to get some more eyes on this since I'm not too familiar with the OIDC/LDAP workflow |
|
Fixed the one failing Python test 😄 |
SurfBurger
approved these changes
Mar 12, 2025
|
Ohh, I'm looking for this! It would be nice if I didn't have to explain to my family that they need to look past the username and password box and go to the |
| @@ -65,7 +67,7 @@ | |||
| @click:append="togglePasswordShow" | |||
| /> | |||
| <v-checkbox v-model="form.remember" class="ml-2 mt-n2" :label="$t('user.remember-me')"></v-checkbox> | |||
There was a problem hiding this comment.
Remember me serves no purpose without password login. There are also a couple other spots that should be conditionally removed:
- The "or" divider
- Reset Password
I'm not sure if it really even makes sense to include the "register" or "invite only" buttons at all if allowPasswordLogin is false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This adds a server config setting to hide the username+password inputs from users on the login page.
This is very useful for installations that use OIDC, and prevents user confusion.
It's been requested in #4581, in a comment in #4477, and arguably in #293.
Which issue(s) this PR fixes:
Fixes #4581
Special notes for your reviewer:
This is my first contribution here, please let me know what more is needed.
Testing
Manually in the dev container.