-
-
Notifications
You must be signed in to change notification settings - Fork 865
feat: Ingredients parser UX - Slightly improve controls #4961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: mealie-next
Are you sure you want to change the base?
feat: Ingredients parser UX - Slightly improve controls #4961
Conversation
Would you consider leaving the Save and Cancel buttons at the top and including a copy of those buttons at the end of the ingredients list? In my experience using the parser, I scroll to the end of the list every time to make sure that every ingredient is correct, and I think it's likely that a lot of people do the same. In that situation, floating the buttons isn't really necessary, and doing it this way would alleviate the issue of having a strange overlay. |
This PR is stale because it has been open 45 days with no activity. |
What this PR does / why we need it:
Rearranges the save/parse/etc controls on ingredient editing so that:
After:

Which issue(s) this PR fixes:
Part of #4954
Special notes for your reviewer:
If there's a preferred style or background for floating action buttons/navs; happy to implement. Current approach overlays content in a weird way.
Testing
Regression tested locally with chrome dev tools (desktop,, mobile).