-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix: Address Ingredients Parser UX overflow issues on mobile #4962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Address Ingredients Parser UX overflow issues on mobile #4962
Conversation
|
Let me know if this should have a general "errors" or "Add missing" prefix when errors.any? |
Kuchenpirat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the concept of this quite a bit but there are still a few things that need improving.
- I feel like it should be visually possible to determin if the parser wants to create a new food or unit (either swaping the plus icon in the button for the food | icon button or appending an icon that matches the type)
- We need to add vertical margin so the cards are no longer right against each other.
- The cards are not all aligned to the right side if they stack which looks quite ugly (screenshot)
|
This PR is stale because it has been open 45 days with no activity. |
|
Not stale, just dependent on the nuxt 3 pr |
|
This PR is stale because it has been open 45 days with no activity. |
|
Hey there! As you might know, we've been working on the upgrade to Nuxt 3 for the past several months, and had to hold on reviewing/merging PRs during that time (especially frontend ones). That work is more-or-less completed, so we've started reviewing PRs again. This PR has merge conflicts preventing us from fully reviewing/testing it. If you're able to resolve those we can get to work on it. Appreciate your patience, we know it's been a bit, but now that the Nuxt 3 upgrade is completed we should be able to get things reviewed much quicker than before. Same with your other PR for the ingredient parser: #4961 We're considering re-doing the parsing flow which may eliminate this page entirely, but I'm not sure how far out that is, so I think it's still worth getting these changes in if you have the time. |
|
Hey there, it looks like this PR is no longer needed with the new ingredient parser. If you're running into the same issues with the new parser feel free to create a new PR or re-open this one with the changes for the new parser. |

What this PR does / why we need it:
Before
Desktop was ok
But mobile cropped error messages if there was more than one or they were long

After:

Which issue(s) this PR fixes:
#4954
Special notes for your reviewer:
This has a slight tradeoff in that the existing call to action ("Create") now relies on the user understanding what the + icon means, unless they hover over and read the title attribute.
The use of
flex-wrapalso looks a bit stupid, but the alternative was a list group; which looked bad on desktop.If the CSS framework has a btn-group-vertical on small screens class; I couldnt find it.
Testing
Tested locally, w/Chrome dev tools for mobile UX.