feat: add basic support for location_groups #85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic support for location_groups, a subset of the GTFS-Flex specification, which is now integrated in the GTFS spec.
I.e, it
location_groups
andlocation_group_stops
as unknown files and validates their columnslocation_group
location_groups
in the statsNote: this is WIP. Currently only UNSORTED StopTimesDaoMode is supported. I'd nevertheless already get some review feedback of you, @laurentg.
Still to do for the minimal implementation:
stop_times
andlocation_group_stops
DEPTIME_MASK
,ARRTIME_MASK
,DEPTIME_SHIFT
,ARRTIME_SHIFT
(or introduce new constants with same values but START_WINDOW/END_WINDOW prefix(?)PackingStopTimes
or fall back toPackingUnsortedStopTimes
inAutoSwitchStopTimesDao
Additional checks that could be added:
endPickupDropOffWindow
times are greater or equal tostartPickupDropOffWindow
location_group_id
is set/unset