Skip to content

[macOS] enable shortcuts #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
mathildemerle wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[macOS] enable shortcuts #1085

mathildemerle wants to merge 1 commit into from

Conversation

@mathildemerle
Copy link
Collaborator

@mathildemerle mathildemerle commented Dec 21, 2022

From an issue on Inria-Asclepios#169

On macOS the shortcuts in Qt applications are disabled by default: https://doc.qt.io/qt-6/qshortcut.html#details

This PR adds the methods which enable shortcuts.

I put the PR in draft since it needs to be tested. It can be tested with the Exit pop-up.

Ⓜ️

@mathildemerle mathildemerle added this to the 4.0 milestone Dec 21, 2022
Florent2305
Florent2305 reviewed Mar 27, 2023
View reviewed changes
Copy link
Member

@Florent2305 Florent2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, just need to test it

@mathildemerle
Copy link
Collaborator Author

mathildemerle commented Mar 30, 2023 •
edited
Loading

Tested on macOS:

  • on master branch, the native macOS menu bar that we use have its own keyboard shortcut to access: control + fn + F2
  • as said by Qt shortcut documentation on macOS even if we enable the shortcuts, the underlined letters as done on linux and windows are not shown in the native menu bar on macOS
  • this qt setting in this PR could be used by other widgets, for instance the "Do you really want to exit?" popup. However, it's not working...

So, the qt shortcut system on macOS is not stable for now on Qt5. We can keep this PR to test when we'll be on Qt6. I put this PR as invalid for now.

@mathildemerle mathildemerle removed this from the 4.0 milestone Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Florent2305 Florent2305 Florent2305 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Invalid

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mathildemerle @Florent2305