Add block.super to correct override behavior #1412
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Commenting to give it a spin. |
Contributor
|
I solved the merge conflict on my side and seems to work -- at least no new errors and pages render properly! Do you happen to have an example template override I can use for testing? I've never done this and aren't sure what would be something to test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request resolves the issue of inconsistent template overrides for the
bottomimportsblock.Many child templates were overriding the block without including
{{ block.super }}, which prevented the base scripts defined inbase.htmlfrom loading on those pages. This change adds{{ block.super }}to all affected templates, ensuring that the parent block's content is always included.This guarantees consistent script loading across the entire application.
Fixes : #1369