feat: Add video player context menu with share/embed options#1472
Merged
feat: Add video player context menu with share/embed options#1472
Conversation
Contributor
|
Looks good. I'd suggest we keep the default behavior, which is fixed sized and not responsive... |
mgogoulos
reviewed
Jan 8, 2026
mgogoulos
reviewed
Jan 8, 2026
eae5793 to
f1e69f7
Compare
Contributor
|
@Yiannistaos what's the status here / is it ready by your side? |
Collaborator
Author
Yes @mgogoulos, this is ready for merge! |
…player - Add VideoContextMenu component with copy URL, URL with timestamp, and embed code options - Integrate context menu into VideoJSPlayer with proper event handling - Add visual feedback via SeekIndicator when copying URLs/embed code - Support embed mode with showTitle URL parameter handling - Handle cross-origin iframe scenarios for embed URL generation - Add helper functions for media ID, origin, and embed URL resolution
- Add showTitle prop support to EmbedInfoOverlay to conditionally show/hide title overlay - Add showTitle checkbox option in MediaShareEmbed dialog with URL parameter support - Update embed code generation to include showTitle parameter - Add copy-url and copy-embed visual feedback icons to SeekIndicator - Support showTitle prop in VideoJSEmbed component
- Added 'showRelated' parameter to control related videos visibility at video end - Implemented UI toggle in MediaShareEmbed for the 'showRelated' option - Updated EndScreenHandler to honor the 'showRelated' setting - Modified EmbedPage and VideoJSEmbed to pass the parameter from URL to player
- Added 'showUserAvatar' parameter to control author avatar visibility in embed info overlay - Implemented UI toggle in MediaShareEmbed for the 'showUserAvatar' option - Propagated 'showUserAvatar' through EmbedPage, VideoViewer, and VideoJSEmbed - Updated test iframe index with all 8 combinations of showTitle, showRelated, and showUserAvatar
- Added 'linkTitle' to toggle between clickable and
Refactored the embed options layout to use a grid for better alignment and spacing. The 'Link title' and 'Show user avatar' checkboxes are now disabled and visually dimmed when 'Show title' is unchecked, improving usability and clarity.
Deleted __test-iframe/index.html and __test-iframe/index2.html as they are no longer needed for testing embedded video functionality.
Changed initial states for keepAspectRatio, showTitle, and responsive options in MediaShareEmbed to improve default embed behavior. Also simplified aspect ratio change logic by removing unit options adjustments.
Introduces an HTML example for embedding a full-screen video using an iframe, styled for centered display and responsive aspect ratio.
Prevent automatic focus on the video element when in embed mode to avoid unexpected behavior. Update scroll logic to only scroll the video into view if not in an iframe, or if explicitly requested via a URL parameter, improving user experience for embedded players.
The aspect ratio dropdown in MediaShareEmbed now only includes horizontal orientation options (16:9, 4:3, 3:2) and the custom option. Vertical orientation options have been removed to simplify the selection.
72e37e7 to
2bf622f
Compare
mgogoulos
pushed a commit
that referenced
this pull request
Feb 6, 2026
## [7.4.0](v7.3.0...v7.4.0) (2026-02-06) ### Features * Add video player context menu with share/embed options ([#1472](#1472)) ([74952f6](74952f6))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR significantly enhances the video player sharing capabilities and embed system. It introduces a new right-click context menu for quick sharing and provides comprehensive customization options for embedded videos, including improved responsive design support.
Features
Right-Click Context Menu
Users can now right-click anywhere on the video player to access a custom context menu:
?t=secondsparameter for deep-linking.Advanced Embed Customization
The "Share/Embed" dialog now features a suite of new options to customize how the video looks on external sites:
Persistent Embed Preferences
Improved Embed Player Logic
Testing
?t=parameter works.Show title,Link title, andShow user avatarand verify the preview updates.showRelatedparameter by letting a video finish in an iframe.Screenshots
Related issues
closes #1458