Pin version for nominatim-api in Dockerfile#635
Merged
Conversation
DrFaust92
changed the title
leonardehrenfried
approved these changes
Nov 4, 2025
Contributor
Author
|
@leonardehrenfried ill take a look |
Contributor
Author
|
leonardehrenfried can this be merged? ill take a look at using uv/lockfile after this is merged |
Contributor
Author
|
Friendly ping — this has been approved and is merge-clean. Could it be merged when you get a chance? Thanks @leonardehrenfried! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
only the nominatim-db dep is pinned. this change will prevent weird issues or misalignment.
Generally i would reccomend moving to poetry or better yet uv and have lockfile and use it to install so all deps have a predictable version