Skip to content

feat: download ffmpeg #1653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

naaa760
Copy link

@naaa760 naaa760 commented Mar 19, 2025

name: download Bundle ffmpeg
about: ship ffmpeg with the app
title: "Feature download ffmpeg "

#1640

/claim #1640

image

Screenshot from 2025-03-19 19-45-57

description

Bundle ffmpeg with the app instead of downloading it at runtime. This improves the initial setup experience for non-technical users while keeping the sidecar ffmpeg as a backup for CLI usage.

Key changes:

  • Add pre-build script to download the correct ffmpeg binary during the build
  • Configure Tauri to bundle ffmpeg in resources
  • Add FfmpegCommand struct to handle bundled/sidecar ffmpeg paths
  • Update the build process to include ffmpeg download step

Related issue: # (add issue number if exists)

how to test

  1. Clean build artifacts and run build:

Launch the app and test the recording functionality

The pre-build script includes detailed logging to help diagnose any issues during ffmpeg download and verification.

Copy link

vercel bot commented Mar 19, 2025

Someone is attempting to deploy a commit to the louis030195's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

🧪 testing bounty created!

a testing bounty has been created for this PR: view testing issue

testers will be awarded $20 each for providing quality test reports. please check the issue for testing requirements.

@brymut
Copy link

brymut commented Mar 25, 2025

Testing this on macos @louis030195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants