Skip to content

fix: screenpipe not working due to IPv6 port and wrong design flow #1748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: screenpipe not working due to IPv6 port and wrong design flow #1748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7fa657b
fix(windows): screenpipe not working due to IPv6 port
divanshu-go Apr 19, 2025
cec9839
Update check_logs.sh
divanshu-go Apr 19, 2025
fcbc4fd
fix design flow
divanshu-go Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/scripts/check_logs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ if grep -q "panic" screenpipe_output.log; then
echo "CLI crashed"
exit 1
fi
if ! grep -a "Server listening on \[::\]:3030" screenpipe_output.log; then
if ! grep -q "Server listening on 0.0.0.0:3030" screenpipe_output.log; then
echo "Server did not start correctly"
exit 1
fi
Expand Down
117 changes: 51 additions & 66 deletions screenpipe-app-tauri/src-tauri/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,23 +753,12 @@ async fn main() {
let _ = File::create(path.clone()).unwrap();
}

// Set up update check
let update_manager = start_update_check(app_handle, 5)?;

// Tray setup
if let Some(_) = app.tray_by_id("screenpipe_main") {
let update_item = update_manager.update_now_menu_item_ref().clone();
if let Err(e) = tray::setup_tray(&app.handle(), &update_item) {
error!("Failed to setup tray: {}", e);
}
}

// Store setup and analytics initialization
// Store setup and initialization - must be done first
let store = StoreBuilder::new(app.handle(), path.clone())
.build()
.unwrap();

// TODO: proper lookup of keys rather than assuming they exist
// Initialize default store values if empty
if store.is_empty() {
store.set("analyticsEnabled".to_string(), Value::Bool(true));
store.set(
Expand All @@ -779,12 +768,55 @@ async fn main() {
store.save()?;
}

// Ensure store is saved and managed
store.save()?;
app.manage(store.clone());

// Get app handle once for all initializations
let app_handle = app.handle().clone();

// Ensure state is managed before calling update_show_screenpipe_shortcut
// Initialize server first (core service)
let server_shutdown_tx = spawn_server(app_handle.clone(), 11435);
app.manage(server_shutdown_tx);

// Initialize sidecar manager and check dev mode
let sidecar_manager = Arc::new(Mutex::new(SidecarManager::new()));
app.manage(sidecar_manager.clone());

// Dev mode check and sidecar initialization
let use_dev_mode = store
.get("devMode")
.and_then(|v| v.as_bool())
.unwrap_or(false);

info!("use_dev_mode: {}", use_dev_mode);

// Start sidecar in non-dev mode (production behavior)
if !use_dev_mode {
let sidecar_manager_clone = sidecar_manager.clone();
let app_handle_clone = app_handle.clone();
tauri::async_runtime::spawn(async move {
let mut manager = sidecar_manager_clone.lock().await;
if let Err(e) = manager.spawn(&app_handle_clone, None).await {
error!("Failed to spawn initial sidecar: {}", e);
}
});
} else {
debug!("Skipping sidecar spawn: dev_mode enabled");
}

// Initialize update check
let update_manager = start_update_check(&app_handle, 5)?;

// Setup tray
if let Some(_) = app_handle.tray_by_id("screenpipe_main") {
let update_item = update_manager.update_now_menu_item_ref().clone();
if let Err(e) = tray::setup_tray(&app_handle, &update_item) {
error!("Failed to setup tray: {}", e);
}
}

// Check analytics settings from store
let is_analytics_enabled = store
.get("analyticsEnabled")
.unwrap_or(Value::Bool(true))
Expand Down Expand Up @@ -837,57 +869,10 @@ async fn main() {
}
}

// Dev mode check and sidecar spawn

let use_dev_mode = store
.get("devMode")
.and_then(|v| v.as_bool())
.unwrap_or(false);

// double-check if they have any files in the data dir
let data_dir = app
.path()
.home_dir()
.expect("Failed to ensure local data directory");

info!("data_dir: {}", data_dir.display());
let has_files = fs::read_dir(data_dir.join(".screenpipe").join("data"))
.map(|mut entries| entries.next().is_some())
.unwrap_or(false);

info!("has_files: {}", has_files);

let sidecar_manager = Arc::new(Mutex::new(SidecarManager::new()));
let sidecar_manager_clone = sidecar_manager.clone();
app.manage(sidecar_manager.clone());

let app_handle = app.handle().clone();

info!("use_dev_mode: {}", use_dev_mode);

info!("will start sidecar: {}", !use_dev_mode && has_files);

// if non dev mode and previously started sidecar, start sidecar
if !use_dev_mode && has_files {
// Start health check service (macos only)
let app_handle_clone = app_handle.clone();
tauri::async_runtime::spawn(async move {
let mut manager = sidecar_manager_clone.lock().await;
if let Err(e) = manager.spawn(&app_handle, None).await {
error!("Failed to spawn initial sidecar: {}", e);
}
});
} else {
debug!("Dev mode enabled, skipping sidecar spawn and restart");
}

// Inside the main function, after the `app.manage(port);` line, add:
let server_shutdown_tx = spawn_server(app.handle().clone(), 11435);
app.manage(server_shutdown_tx);

// Start health check service
// macos only
let app_handle = app.handle().clone();
tauri::async_runtime::spawn(async move {
if let Err(e) = start_health_check(app_handle).await {
if let Err(e) = start_health_check(app_handle_clone).await {
error!("Failed to start health check service: {}", e);
}
});
Expand All @@ -896,9 +881,9 @@ async fn main() {
app.set_activation_policy(tauri::ActivationPolicy::Regular);

// Initialize global shortcuts
let app_handle = app.handle().clone();
let app_handle_clone = app_handle.clone();
tauri::async_runtime::spawn(async move {
if let Err(e) = initialize_global_shortcuts(&app_handle).await {
if let Err(e) = initialize_global_shortcuts(&app_handle_clone).await {
warn!("Failed to initialize global shortcuts: {}", e);
}
});
Expand Down
4 changes: 2 additions & 2 deletions screenpipe-server/src/bin/screenpipe-server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ use screenpipe_vision::run_ui;
use serde_json::{json, Value};
use std::{
env, fs, io::Write, net::SocketAddr, ops::Deref, path::PathBuf, sync::Arc, time::Duration,
net::{IpAddr, Ipv6Addr},
net::{IpAddr, Ipv4Addr},
};
use tokio::{runtime::Runtime, signal, sync::broadcast};
use tracing::{debug, error, info, warn};
Expand Down Expand Up @@ -745,7 +745,7 @@ async fn main() -> anyhow::Result<()> {

let server = SCServer::new(
db_server,
SocketAddr::new(IpAddr::V6(Ipv6Addr::UNSPECIFIED), cli.port),
SocketAddr::new(IpAddr::V4(Ipv4Addr::UNSPECIFIED), cli.port),
local_data_dir_clone_2,
pipe_manager.clone(),
cli.disable_vision,
Expand Down
Loading