Skip to content

Conversation

@fPolic
Copy link
Contributor

@fPolic fPolic commented Dec 17, 2025

What

  • manage products options form improvements
  • delete exclusive options when associated product is deleted
  • reorganise deleteProducts workflow
  • product options soft deletion cascades to the pivot tables
  • reorganize the product option create form
    • merge tabs into single modal
    • fix setting the default ranking

CLOSES CORE-1316
CLOSES CORE-1317
CLOSES CORE-1318
CLOSES CORE-1320
CLOSES CORE-1321

@vercel
Copy link

vercel bot commented Dec 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

8 Skipped Deployments
Project Deployment Review Updated (UTC)
api-reference Ignored Ignored Dec 19, 2025 3:58pm
api-reference-v2 Ignored Ignored Preview Dec 19, 2025 3:58pm
cloud-docs Ignored Ignored Preview Dec 19, 2025 3:58pm
docs-ui Ignored Ignored Preview Dec 19, 2025 3:58pm
docs-v2 Ignored Ignored Preview Dec 19, 2025 3:58pm
medusa-docs Ignored Ignored Preview Dec 19, 2025 3:58pm
resources-docs Ignored Ignored Preview Dec 19, 2025 3:58pm
user-guide Ignored Ignored Preview Dec 19, 2025 3:58pm

@changeset-bot
Copy link

changeset-bot bot commented Dec 17, 2025

⚠️ No Changeset found

Latest commit: 2d8b2f2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@fPolic fPolic changed the title wip: product options catch-all imporvements fix: product options catch-all improvements Dec 18, 2025
@fPolic fPolic marked this pull request as ready for review December 19, 2025 10:14
@fPolic fPolic requested a review from a team as a code owner December 19, 2025 10:14
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

enabled: !!selectedOptionIds.length,
}
)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: New options may submit with undefined value_ids

When a user adds a new global option, handleProductOptionSelect attempts to initialize its values from product_options. However, since useProductOptions now fetches only by selectedOptionIds, the newly selected option isn't available in product_options until the query re-runs. The new option's values never get initialized in selectedOptionValues. On form submit, data.option_values[newId] evaluates to undefined, resulting in { id: newId, value_ids: undefined } being sent to the backend, which could cause API errors.

Additional Locations (1)

Fix in Cursor Fix in Web

@fPolic fPolic marked this pull request as draft December 19, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants