Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: workflow internals improvementss #9455

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from
Open

chore: workflow internals improvementss #9455

wants to merge 20 commits into from

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Oct 3, 2024 •
edited
Loading

What

  • Now transformer results are temporarily stored in the distributed transaction for its life time
  • Deep copy will not run on proxies which prevents running proxies for every property increasing the CPU usage and blocking the event loop
  • refactored the context creation for steps to be in a separate function and shared for compensate and invoke

@vercel Vercel
Copy link

vercel bot commented Oct 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 6:02pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Oct 4, 2024 6:02pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 6:02pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 6:02pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 6:02pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 6:02pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 6:02pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a2b92b7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@adrien2p adrien2p marked this pull request as ready for review October 4, 2024 13:12
@adrien2p adrien2p requested a review from a team as a code owner October 4, 2024 13:12
@adrien2p adrien2p changed the title Chore/add to cart workflow improvements chore: workflow internals improvementss Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

@christiananese christiananese Awaiting requested review from christiananese christiananese is a code owner automatically assigned from medusajs/engineering

@carlos-r-l-rodrigues carlos-r-l-rodrigues Awaiting requested review from carlos-r-l-rodrigues carlos-r-l-rodrigues is a code owner automatically assigned from medusajs/engineering

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
team: medusa type: chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrien2p @carlos-r-l-rodrigues