Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/update price #9475

Draft
wants to merge 35 commits into
base: develop
Choose a base branch
from
Draft

Feat/update price #9475

wants to merge 35 commits into from

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Oct 4, 2024

No description provided.

riqwan and others added 30 commits October 1, 2024 11:56
**What**
- set product title and sales channels column widths to a reasonable value so the scroll is visible on mobile resolutions only

---

FIXES CC-527
* chore: Improve instrumentation loading

* fix build

* fix buildgst
…urrencies (#9361)

**What**
- Fixes an issue where the admin dashboard would send region prices for deleted regions.
- Also, includes the implementation for `GET /admin/shipping-options/:id` and its corresponding SDK function.

**Why**
- When a region price for a deleted region was sent to the backend it would result in the insert hitting a not null constraint on the currency_code for prices. To avoid this the dashboard should not send region prices for deleted regions. 

**Additional context**
- Prices for deleted regions should ideally not be returned when fetching shipping option prices. However, we don't yet have a mechanism for cleaning up region prices after a region is deleted.

Fixes CC-540
**What**
- Removes broken cart retrieval step `retrieveWithCartLinks` in favor of `useRemoteQueryStep` in `updateTaxLinesWorkflows`

**Why**
- Filters variables in the step were passed with an incorrect shape
  - I removed the step, since it's only used once and the behavior is identical to the generic remote query step

**Note**
- Because the filters were passed incorrectly, the, now-removed, step has always returned the first cart in the database. As a result all tax calculations so far have been based on whatever the shape of that cart has. It basically ignores all input to this workflow
**What**
- validate quantity range when creating validation and handle form errors nicely

---

CLOSES CC-470
**What**
- fix listing/adding products in the add category products flow

---

FIXES CC-523
**Why**
- price set update uses `upsertWithReplace` so price list prices are removed since we "ignore" them in regular price set operations and use price list methods to manage them

**What**
- preserve price list prices when updating price sets

---

FIXES CC-516
* docs: update imports and package names across docs
+ reference configs

* generate files

* fix import

* change preview to rc
**What**
- unset datagrid currency cell on delete press instead of setting it to 0
- consolidate pricing editors validations
- fix PL edit pricing schema

---

FIXES CC-529
Spelling issue with perform, Fixed it!
- Split Module and Module Links to their own chapters
- Add new docs on db operations and transactions in modules, multiple services, links with custom columns, etc...
- Added a list of registered dependencies in a module container
* clean up generated oas

* fix issues in docs-util

* more fixes

* align max level

* validation fix

* add missing summaries

* fix validation

* fix exchanges route
shahednasser and others added 5 commits October 2, 2024 15:50
* fix config + update deps

* rearrange sidebar + add to examples
* fix(types, medusa): http types fixes

* fix build error

* remove return fields

* more fixes

* fix cart payload types
* fix(medusa-oas-cli): Fix incorrect import

* update redocly config
Copy link

changeset-bot bot commented Oct 4, 2024

⚠️ No Changeset found

Latest commit: ed64e0a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 3:31pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 3:31pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 3:31pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 3:31pm
docs-v2 ⬜️ Ignored (Inspect) Oct 4, 2024 3:31pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 3:31pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 3:31pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants