Fix incorrect Slack notification Badge#13
Open
Serubin wants to merge 1 commit intomeetfranz:masterfrom
Open
Conversation
Author
|
Bumping this. This PR has been sitting open for almost a month now. |
Serubin
added a commit
to Serubin/recipes
that referenced
this pull request
Feb 11, 2020
Serubin
added a commit
to Serubin/recipes
that referenced
this pull request
Feb 11, 2020
Serubin
added a commit
to Serubin/recipes
that referenced
this pull request
Feb 11, 2020
|
This fix would be very welcome (as it fixes an annoying issue that has been present for a few months now). |
Author
|
It's fixed in Ferdi. Franz is dead as far as I'm concerned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently slack will show 1 notification even if there are zero. This is due to a code change in Slack.
I changed the current CSS selector ignore the "All Unreads" channel.