Make it look more like the Telegram desktop app#13
Open
joeytwiddle wants to merge 13 commits intomeetfranz:masterfrom
Open
Make it look more like the Telegram desktop app#13joeytwiddle wants to merge 13 commits intomeetfranz:masterfrom
joeytwiddle wants to merge 13 commits intomeetfranz:masterfrom
Conversation
e0ae0be to
10b55fe
Compare
c51e262 to
48d21db
Compare
|
Your screenshots are a bit broken |
Author
|
Sorry, they are intentionally like that. I wanted to anonymise them! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed the layout and colours in light-mode to make the Telegram in Franz look more like the Telegram desktop app. It's still not an exact clone, but it's closer!
I then did the same for dark-mode, based on magazov's branch.
Some things still TODO:
!importantwe could have made the selector more specific e.g. by puttingbodyin front. But that won't always work.(The issue here is that sometimes our CSS appears in the DOM before Telegram's CSS, and sometimes after. This behaviour appears to be inconsistent. If we cannot consistently load our stylesheet after Telegram's, then we need to take extra measures to override their CSS rules.)
This PR will close https://github.com/meetfranz/franz/issues/1240