docs: add stateless validator guide#39
Conversation
ReviewGood addition — well-structured, thorough CLI reference, and the metrics table is genuinely useful. A few things to address before merging. Missing Four inline comments on specific lines — see the diff for details:
|
|
Good overall — well-structured, covers the full operator lifecycle, and the CLI flag tables are thorough. A few issues to resolve before merging: 4 existing threads still open (not yet addressed):
2 new issues (inline comments added):
|
ReviewThe stateless validator guide is well-structured and thorough — the systemd deployment section, flag/metric tables, and troubleshooting entries are exactly right for this audience. Must fix before merge:
Prior threads still unresolved — please address:
Resolved this round: genesis file link (now correctly points to the specific file in the repo) and systemd example request (now fully addressed). |
|
Good progress — the systemd rewrite and Two remaining items:
|
ReviewSolid, well-structured guide — covers the full operator lifecycle from first-run anchoring through systemd hardening and monitoring. The layer AGENTS.md is a good addition and the flag/env-var tables are clear. Resolved stale threads — the three open threads (heading case, trailing backslash, One remaining issue — see inline comment on the monitoring section: the Minor suggestion — the Otherwise this is ready. |
|
Review: LGTM with no blocking issues All previous threads have been addressed and resolved. What's here: Specifically confirmed:
Ready to merge once the requested reviewers sign off. |
|
All 18 previous review threads are resolved — the doc is in solid shape. One remaining inconsistency flagged inline: the Prometheus example output and the "During initial catch-up" explanation still carry the old 0xc0ffee anchor numbers (12.6M local, 14M remote, 1.4M lag). Since the Quick Start now anchors at |
|
All previous review threads are resolved. One item remains before merging: Open thread (monitoring section): The example output in the Otherwise the guide is solid: copy-pasteable commands are correct, the systemd pattern is clean, rate-limit caps are in place for the public RPC, and the flag/metric tables match upstream source. |
ReviewThis is a high-quality, well-structured addition. The previous review round was thorough and nearly all issues have been addressed — copy-pasteable commands are correct, the systemd deployment is production-grade, the metrics table is comprehensive, and the one-sentence-per-line rule is followed throughout. One open thread still needs resolution: the monitoring example output. Thread But the Quick Start now anchors at the finalized block (near tip), so a user following the guide as written will see The fix from the existing thread works: update the example numbers to show near-tip operation (lag ≈ 6), and drop or generalise the hardcoded "12.6M / 14M / ~1.4M" phrasing in the bullets. The surrounding explanation about Everything else is ready to merge once this is addressed. |
ReviewAll previous threads have been addressed except for one — the monitoring section example output. Two small items remain. Remaining issues
Everything elseThe rest of the guide is in good shape: flags/env vars/metric tables match upstream source, systemd unit includes rate-limit caps, log tail commands use the correct env var, and one-sentence-per-line formatting is clean throughout. |
|
All previous review threads are now addressed. The latest iteration looks ready:
No new issues found. LGTM. |
|
All previous threads resolved. Fresh pass on the latest revision finds nothing new to flag:
LGTM. |
|
All 26 previous threads are resolved. One new issue flagged inline (broken sentence in the monitoring section). Otherwise this is in good shape — the Quick Start is accurate and safe, flag/env-var tables are consistent with source, Prometheus examples use |
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Signed-off-by: liquan.eth <flyq951@gmail.com>
|
All prior review threads are resolved. Reviewed the latest diff — no remaining issues. The document is accurate, well-structured, and follows the layer's conventions:
Ready to merge. |
|
All 24 prior threads are resolved. The document is technically accurate, follows conventions, and the Quick Start is copy-paste safe after previous rounds of live testing. One remaining nit (not a blocker): the tail -f "$STATELESS_LOG_FILE_DIRECTORY/stateless-validator.log"If the user passed tail -f ./validator-data/stateless-validator.logWorth fixing before merge, but fine to address as a follow-up if the PR is otherwise ready to ship. |
|
This is a thorough, well-structured operator reference. 24 of the 25 prior review threads have been resolved. One issue remains open and needs a fix before merge. Remaining issue — The open thread on The fix: align it with the hardcoded Note: the existing thread's suggestion ( No other issues found in the current revision. |
|
All 27 review threads are now resolved. The last open thread flagged Fresh pass on the latest revision — no new issues:
LGTM — ready to merge. |
Summary
Adds a new Stateless Validator documentation layer at
docs/stateless/, targeting node operators running the upstreamstateless-validatorRust client.Changes
New page:
docs/stateless/stateless-validator.md— end-to-end operator reference, covering:--genesis-file/--start-block; subsequent runs)clapdefinitionsLogArgs: filters, formats, rotation)metrics::namesop-node/ replica nodesNew layer rules:
docs/stateless/AGENTS.md— writing conventions for the stateless layer (reference tone, copy-pasteable commands, placeholder style, verification-against-source requirement before editing flag/metric tables).docs/SUMMARY.md— adds the "Stateless Validator" section so GitBook navigation picks up the new page.AGENTS.md(root) — registers the new layer in the architecture table and the project tree.docs/AGENTS.md— addsstateless/to the list of layers that use the terse reference tone.Test plan
stateless-validatorsource