Draft: http retry 5xx by default #493
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #493 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 44 44
Lines 6391 6391
=======================================
Hits 6390 6390
Misses 1 1 ☔ View full report in Codecov by Sentry. |
bbtfr
commented
Jan 25, 2025
| stream=None, | ||
| verify=None, | ||
| cert=None, | ||
| json=None, |
There was a problem hiding this comment.
这堆参数感觉好像没必要，看起来是想支持位置参数，不过看到
- request.Session 里的调用 get / post / etc. 都是用 kwargs 传 data 之后的参数的
- 这里打 patch 的只是当前 session 对象，不会影响到其他 session 对象
所以似乎只用关心 megfile 内部调用到的方法不会用位置参数就行，这个很好保证
There was a problem hiding this comment.
files 以上主要是保持参数的顺序，以防真有用户按顺序传参，下面的属于顺手复制过去的
| @@ -178,7 +166,7 @@ def open( | |||
| timeout = request_kwargs.pop("timeout", DEFAULT_TIMEOUT) | |||
| stream = request_kwargs.pop("stream", True) | |||
| try: | |||
| response = get_http_session(timeout=timeout, status_forcelist=()).get( | |||
| response = get_http_session(timeout=timeout).get( | |||
There was a problem hiding this comment.
默认重试 500 感觉不太好，毕竟服务器错误一般来接重试是解决不了的，上面没改是为了保持接口的兼容，感觉可以大版本改成统一 500 不重试
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.