Skip to content

Make splitnode only refers to tree nodes #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Make splitnode only refers to tree nodes #127

wants to merge 11 commits into from

Conversation

irevoire
Copy link
Member

@irevoire irevoire commented May 21, 2025 •
edited
Loading

Pull Request

Related issue

Fixes #119

What does this PR do?

  • Update the codec of splitnodes to not contain items
  • Simplify all the writer+parallel code with this new assumption (a lot of matches and ifs can be removed)
  • Introduce a new kind of node that abstracts over the version. It mixes the concept for all versions and supports a decoder for the pre-v1.7 and v1.7.
  • Rewrite all the methods in the reader to support reading in a previous database version. That simplifies a few things from the last PR.
  • Update the upgrade code to support new changes in the latest version
  • Update the upgrade test code to ensure we can read an old database as expected
  • Fix Arroy doesn't properly write the version of the database #128

irevoire
irevoire commented May 21, 2025
View reviewed changes
@irevoire irevoire marked this pull request as ready for review May 21, 2025 16:04
@irevoire irevoire added indexing Everything related to indexing db-breaking labels May 21, 2025
@irevoire irevoire force-pushed the stop-pointing-to-items-in-split-nodes branch from fc4bea7 to b15d43b Compare May 21, 2025 16:14
@irevoire irevoire added this to the v1.7.0 milestone May 21, 2025
ManyTheFish
ManyTheFish requested changes May 22, 2025
View reviewed changes
@irevoire irevoire force-pushed the stop-pointing-to-items-in-split-nodes branch from 22044f0 to 703bfdc Compare May 22, 2025 14:59
@irevoire irevoire requested a review from ManyTheFish May 22, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManyTheFish ManyTheFish Awaiting requested review from ManyTheFish

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
db-breaking indexing Everything related to indexing
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

Arroy doesn't properly write the version of the database Stop pointing to item directly in split nodes
2 participants
@irevoire @ManyTheFish