Make the Env<WithTls> the default
#327
Merged
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerollmops
force-pushed
the
env-default-with-tls
branch
from
9ca9c26 to
c40b23d
Compare
Contributor
|
Hello, what is the motivation here? I find that having to explicitly indicate which variant of env we want is good and rather unobstrusive |
Member
Author
|
Hey 👋 It removes one breaking change and is similar to the change we did for the |
dureuill
approved these changes
Mar 11, 2025
Contributor
dureuill
left a comment
dureuill
left a comment
There was a problem hiding this comment.
we'll have to be careful when integrating in Meilisearch to define all Env as Env<WithoutTls>. Otherwise, approved
Contributor
|
What happens if we don’t? We should get an error when we try to share a RoTxn through multiple threads, right? It won’t silently crash? |
Member
Author
|
Ahah, I already had to make them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.