preserve cmp functions with DatabaseOpenOptions::types
#353
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boog900
force-pushed
the
preserve-cmp
branch
from
c622a5b to
bf940e1
Compare
Kerollmops
approved these changes
Nov 20, 2025
Member
Kerollmops
left a comment
Kerollmops
left a comment
There was a problem hiding this comment.
Ho wow! You are right! My bad on that 🤦♂️ Thank you @Boog900 😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What does this PR do?
Changes the
DatabaseOpenOptions::typesmethod to preserve the compare functions on the database, currently it resets them to the default which can lead to some hard to debug issues if this is used after setting the cmp types.