Add showPerformanceDetails option to search endpoints#707
Add showPerformanceDetails option to search endpoints#707Dejmenek wants to merge 5 commits intomeilisearch:mainfrom
Conversation
Added tests to SearchTests.cs to verify correct handling of the PerformanceDetails property in search results. Tests cover basic, paginated, and similar document searches, both with and without the ShowPerformanceDetails flag. Ensures Meilisearch client returns performance details only when requested.
Added two tests to MultiIndexSearchTests.cs to verify the behavior of the PerformanceDetails property in multi-index search results. One test checks that PerformanceDetails is populated when ShowPerformanceDetails is true, and another ensures it is null when the flag is not set. This ensures correct handling of the PerformanceDetails feature in search queries.
📝 WalkthroughWalkthroughThe changes introduce support for the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Important Action Needed: IP Allowlist UpdateIf your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:
Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/Meilisearch/PaginatedSearchResult.cs`:
- Line 26: The XML doc for the PaginatedSearchResult constructor/property
contains a stray double-quote at the end of the <param
name="performanceDetails"></param>" line; remove the trailing double-quote so
the XML doc is well-formed and the <param name="performanceDetails"> tag closes
properly in PaginatedSearchResult.cs.
| /// <param name="matchesPosition"></param> | ||
| /// <param name="facetStats"></param> | ||
| /// <param name="indexUid"></param> | ||
| /// <param name="performanceDetails"></param>" |
There was a problem hiding this comment.
Remove stray quote in XML doc.
The trailing " in the param doc will render incorrectly.
✅ Fix
- /// <param name="performanceDetails"></param>"
+ /// <param name="performanceDetails"></param>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| /// <param name="performanceDetails"></param>" | |
| /// <param name="performanceDetails"></param> |
🤖 Prompt for AI Agents
In `@src/Meilisearch/PaginatedSearchResult.cs` at line 26, The XML doc for the
PaginatedSearchResult constructor/property contains a stray double-quote at the
end of the <param name="performanceDetails"></param>" line; remove the trailing
double-quote so the XML doc is well-formed and the <param
name="performanceDetails"> tag closes properly in PaginatedSearchResult.cs.
Pull Request
Related issue
Fixes #706
What does this PR do?
This PR adds a new
showPerformanceDetailsoption to search endpoints (search, multi-search and similar documents). I've written needed tests to make sure everything works smoothly.PR checklist
Please check if your PR fulfills the following requirements:
Summary by CodeRabbit
Release Notes
New Features
Tests