Limit redefinition in DocumentsQuery

[Azanul]

Pull Request

Related issue

Fixes #331

What does this PR do?

• Adds support for sending 0 (zero) Limit when querying documents
• Adapts respective tests
• Regenerates easyjson file

PR checklist

Please check if your PR fulfills the following requirements:

• Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
• Have you read the contributing guidelines?
• Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

[brunoocasali]

@Azanul is this PR finished? Can we review it?

[Azanul]

@brunoocasali I don't know if the discussion in the linked issue was conclusive or not. If so then yes. But let me fix the failing tests first.

[alallema]

Hi @Azanul,

I don't know if the discussion in the linked issue was conclusive or not.

Indeed, the discussion was not concluded, but as said in my comment, I would lean toward the NoLimit global variable option. Again I apologize for the delay 😊

[Azanul]

@alallema @aldy505 I've updated the implementation and the tests according to global var approach.

[Azanul]

@brunoocasali Now it's ready for review

[aldy505]

Here are my suggested changes. You can directly apply it by pressing the "commit suggested changes", otherwise you can retype and commit it yourself.

[Azanul]

@alallema Seems like newly added Filter code doesn't respect Limit. Do you want me to update respectively.

[brunoocasali]

@alallema Seems like newly added Filter code doesn't respect Limit. Do you want me to update respectively.

Yes that would be nice @Azanul :)

[Azanul]

@alallema @brunoocasali @aldy505 Do any of you know how I can adapt the current approach for adding 0 Limit support to work with the existing Filter implementation.
I can go back to pointer approach or I'll have to make changes to Filter implementation.

[alallema]

Hi @Azanul,
Thank you so much for all your hard work on this PR.
Unfortunately, we are reducing the support on this repo, and as this issue is not essential and will have to be postponed for Task, Keys etc. I propose to close it.
Thanks again for your involvement and participation ❤️