Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat Language settings & search parameter #580

Merged
merged 8 commits into from
Oct 2, 2024

Conversation

Ja7ad
Copy link
Collaborator

@Ja7ad Ja7ad commented Oct 2, 2024

Pull Request

Related issue

Fixes #575

What does this PR do?

  • Add language settings and search parameter

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@Ja7ad Ja7ad requested a review from curquiza October 2, 2024 07:09
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.65%. Comparing base (1cd56a5) to head (63cf6b8).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
index_settings.go 90.69% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #580      +/-   ##
==========================================
+ Coverage   87.58%   87.65%   +0.07%     
==========================================
  Files          13       13              
  Lines        2247     2293      +46     
==========================================
+ Hits         1968     2010      +42     
- Misses        170      172       +2     
- Partials      109      111       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ja7ad Ja7ad added the enhancement New feature or request label Oct 2, 2024
locate.go Outdated Show resolved Hide resolved
.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved
.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiice

bors merge

Copy link
Contributor

meili-bors bot commented Oct 2, 2024

@meili-bors meili-bors bot merged commit 92b1ab7 into meilisearch:main Oct 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.10.0] Language settings & search parameter
2 participants