Bump meilisearch to v0.57.0#1469
Conversation
🦋 Changeset detectedLatest commit: 2380b4e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughUpdates Node.js requirement to v20.19.0+, adds Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/instant-meilisearch/src/types/types.ts (1)
36-37: Remove the non-essential alias comment on Line 36.
Meilisearchis already self-descriptive; dropping this explanatory comment would better match the repo’s comment style preference.As per coding guidelines, "Prefer self-descriptive code to comments. Only use comments for complex logic."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/instant-meilisearch/src/types/types.ts` around lines 36 - 37, Remove the non-essential comment above the type alias by deleting the line that reads "/* The Meilisearch client class type (instance shape). */" so only the self-descriptive type alias export type Meilisearch = MeilisearchClient remains; locate the declaration of the Meilisearch type alias (symbol: Meilisearch) and remove the explanatory comment while leaving the alias and MeilisearchClient reference intact.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/instant-meilisearch/src/types/types.ts`:
- Around line 36-37: Remove the non-essential comment above the type alias by
deleting the line that reads "/* The Meilisearch client class type (instance
shape). */" so only the self-descriptive type alias export type Meilisearch =
MeilisearchClient remains; locate the declaration of the Meilisearch type alias
(symbol: Meilisearch) and remove the explanatory comment while leaving the alias
and MeilisearchClient reference intact.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 87705952-1b11-423c-af5b-e6d550af59bd
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (21)
.github/actions/set-up-node/action.yml.nvmrcCONTRIBUTING.mdpackage.jsonpackages/autocomplete-client/README.mdpackages/autocomplete-client/__tests__/test.utils.tspackages/autocomplete-client/package.jsonpackages/instant-meilisearch/README.mdpackages/instant-meilisearch/__tests__/assets/utils.tspackages/instant-meilisearch/__tests__/search-resolver.test.tspackages/instant-meilisearch/package.jsonpackages/instant-meilisearch/src/adapter/search-request-adapter/search-params-adapter.tspackages/instant-meilisearch/src/adapter/search-request-adapter/search-resolver.tspackages/instant-meilisearch/src/cache/init-facets-distribution.tspackages/instant-meilisearch/src/client/instant-meilisearch-client.tspackages/instant-meilisearch/src/types/types.tspackages/instant-meilisearch/vite.config.tsplaygrounds/autocomplete/setup.mjsplaygrounds/local-react/setup.mjsplaygrounds/node-env/index.jstsconfig.json
There was a problem hiding this comment.
Hmm, the meilisearch global will no longer work if anyone used it like that (although I doubt many did). Wouldn't it be better if we made the same changes here as well? And show users how to import the ESM version in HTML scripts? I can make a separate PR if you want me to.
e9da3df to
574319a
Compare
|
@flevi29, I agree, we can move to ESM here, too. I changed this to a |
|
@Strift #1471 sets meilisearch as a peer dependency, this means that the lowest working version is required by the plugin, but ultimately the user has to install it (some package managers do it automatically otherwise). So I guess that part of this PR is superseded. |
574319a to
58b49f2
Compare
|
Hey @flevi29, I reworked the PR after rebasing off your work; let me know if this looks good 🙏 |
Pull Request
Why
Bump
meilisearchto v0.57 and align dependencies requirementsWhat does this PR do?
meilisearchdependency to v0.57.0MeiliSearch*exports (with capital S) as deprecated; export the lowercase replacementsMigration guide
The following types are now deprecated and will be removed in the future minor release:
MeiliSearch, useMeilisearchinstead (lowercase 's')MeiliSearchMultiSearchParams, useMeilisearchMultiSearchParams(lowercase 's')AI disclosure
Cursor with
gpt-5.4-medium,gpt-5.1-high,composer-2, andcodex-5.3-spark.PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!
Summary by CodeRabbit
Chores
Documentation