-
Notifications
You must be signed in to change notification settings - Fork 92
Improve Settings
types
#1864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Improve Settings
types
#1864
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1864 +/- ##
==========================================
- Coverage 99.02% 98.79% -0.24%
==========================================
Files 18 19 +1
Lines 1435 1161 -274
Branches 303 252 -51
==========================================
- Hits 1421 1147 -274
Misses 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.
Pull Request
What does this PR do?
Settings
typessetting
of theIndex
classMigration
client.index(uid).updateSettings
now requires the typeUpdatableSettings
instead of justSettings
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!