Skip to content

Switch from yarn to npm, improve workflows, add provenance to published package #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

flevi29
Copy link
Collaborator

@flevi29 flevi29 commented Mar 26, 2025

Pull Request

What does this PR do

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@flevi29 flevi29 added the maintenance Issue about maintenance (CI, tests, refacto...) label Mar 26, 2025
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.17%. Comparing base (b74efe8) to head (6e41796).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1899      +/-   ##
==========================================
+ Coverage   98.53%   99.17%   +0.63%     
==========================================
  Files          16       16              
  Lines        1574     1574              
  Branches      343      348       +5     
==========================================
+ Hits         1551     1561      +10     
+ Misses         23       13      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@flevi29 flevi29 added the dependencies Pull requests that update a dependency file label Mar 26, 2025
@Strift
Copy link
Collaborator

Strift commented Mar 27, 2025

This looks good to me. Although, I prefer merging this after we're done with the v1.14 release.

Happy to merge the ts-eslint changes before though. Is there any reason for grouping them in this PR?

@flevi29
Copy link
Collaborator Author

flevi29 commented Mar 27, 2025

@Strift I'll separate it. npm gave peer dependency errors, I had to update it, that's why I grouped it.

@flevi29
Copy link
Collaborator Author

flevi29 commented Mar 27, 2025

@Strift #1900

@flevi29 flevi29 linked an issue Mar 27, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maintenance Issue about maintenance (CI, tests, refacto...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch package manager to pnpm or npm
2 participants