Skip to content

Conversation

@Strift
Copy link
Collaborator

@Strift Strift commented Dec 23, 2025

Pull Request

Following the move to OIDC tokens (configured by @curquiza on npm), we can remove the node auth token from the publish.yml workflow.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Summary by CodeRabbit

  • Chores
    • Updated the publishing workflow to adjust authentication handling for release deployments.

✏️ Tip: You can customize this high-level summary in your review settings.

@Strift Strift requested a review from flevi29 December 23, 2025 00:34
@coderabbitai
Copy link

coderabbitai bot commented Dec 23, 2025

Walkthrough

The pull request removes NODE_AUTH_TOKEN environment variable blocks from two Publish steps in the GitHub Actions workflow file, eliminating explicit token injection for both "latest" and "beta" publish paths without altering control flow or step ordering.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Configuration
.github/workflows/publish.yml
Removed NODE_AUTH_TOKEN environment variable blocks from two Publish steps (latest and beta), eliminating explicit NPM authentication token injection during package publishing.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main change: removing NODE_AUTH_TOKEN from the publish workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/update-publish-workflow

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Strift Strift requested a review from curquiza December 23, 2025 00:34
@Strift Strift added the maintenance Issue about maintenance (CI, tests, refacto...) label Dec 23, 2025
@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.57%. Comparing base (6a9121f) to head (05efc76).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2098   +/-   ##
=======================================
  Coverage   97.57%   97.57%           
=======================================
  Files          17       17           
  Lines         619      619           
  Branches       96       96           
=======================================
  Hits          604      604           
  Misses         14       14           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Issue about maintenance (CI, tests, refacto...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants