Skip to content

Conversation

@flevi29
Copy link
Collaborator

@flevi29 flevi29 commented Jan 4, 2026

Pull Request

What does this PR do?

I'm really not sure why this happens, because we git ignore every build artifact. I suspect it's because of how actions/checkout works, initially everything is uncommitted. I'll have to investigate more. Sorry @Strift for the trouble.

Summary by CodeRabbit

  • Chores
    • Optimized the automated package release workflow with configuration updates to improve consistency and reliability across all version distributions, including both standard and beta releases.

✏️ Tip: You can customize this high-level summary in your review settings.

@flevi29 flevi29 added the maintenance Issue about maintenance (CI, tests, refacto...) label Jan 4, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 4, 2026

📝 Walkthrough

Walkthrough

The pull request adds the --no-git-checks flag to two pnpm publish commands in the GitHub Actions publish workflow, affecting both the latest and beta release steps. No control flow, error handling, or branching logic is altered.

Changes

Cohort / File(s) Summary
GitHub Actions Publish Workflow
.github/workflows/publish.yml
Added --no-git-checks flag to both pnpm publish commands: the latest-tag step and the beta-tag step. Each command now includes the flag to skip git cleanliness validation during publishing.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • curquiza

Poem

🐰 A flag so small, yet mighty in its way,
Skips the git checks on publishing day,
No cleanliness needed, let workflows run free,
With --no-git-checks, smooth as can be! ✨

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Disable publish git protections' directly and clearly describes the main change: adding the --no-git-checks flag to npm publish commands in the GitHub Actions workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c4089b4 and c2e4778.

📒 Files selected for processing (1)
  • .github/workflows/publish.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: integration-tests (Node.js 20)
  • GitHub Check: integration-tests (Node.js 22)
🔇 Additional comments (1)
.github/workflows/publish.yml (1)

30-30: This is the correct pattern for CI/CD publishing—no changes needed.

The --no-git-checks flag is a standard and recommended practice in CI/CD workflows. The workflow correctly follows the pattern: checkout code → run build (which creates dist/ artifacts) → publish with --no-git-checks. Since dist/ is gitignored, the git working directory check would fail without this flag, making it the appropriate solution rather than a workaround masking a problem.

Likely an incorrect or invalid review comment.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Jan 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.60%. Comparing base (c4089b4) to head (c2e4778).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2112   +/-   ##
=======================================
  Coverage   97.60%   97.60%           
=======================================
  Files          17       17           
  Lines         625      625           
  Branches      100      100           
=======================================
  Hits          610      610           
  Misses         14       14           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Strift Strift added the skip-changelog The PR will not appear in the release changelogs label Jan 5, 2026
Copy link
Collaborator

@Strift Strift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, thanks for submitting a followup PR 🙏

@Strift Strift added this pull request to the merge queue Jan 5, 2026
Merged via the queue into meilisearch:main with commit 5e4e915 Jan 5, 2026
7 checks passed
@flevi29 flevi29 deleted the no-git-checks branch January 5, 2026 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Issue about maintenance (CI, tests, refacto...) skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants