-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename MeiliSearch to Meilisearch #384
base: main
Are you sure you want to change the base?
Conversation
Please do not merge until the time comes to update to |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #384 +/- ##
==========================================
+ Coverage 89.54% 89.56% +0.01%
==========================================
Files 13 13
Lines 775 776 +1
==========================================
+ Hits 694 695 +1
Misses 81 81 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0b48285
to
b09944e
Compare
b09944e
to
44542b6
Compare
I don't think we can put this off much longer, all the tests pass in the current state, I don't think this breaks anything ( 👀 ) I'll start work on federated search on top of this. |
@ellnix, thanks for all your work on this and #393! @brunoocasali @curquiza, I'm very sorry to ping you directly and would be happy to contribute my and my team's resources in any way necessary to help get this and #393 over the line. I know that you must be spread thin and I can't sympathize enough with the burden of maintaining open source projects, so I really don't intend to be a pest. My team relies on federated search as a hard requirement, and would gain some immediate tangible benefits from switching to the |
@wesharper Do you mean that you are not currently using the rails gem at all and just using ms-ruby? Or that you have your own federated search implementation on top of ms-rails? |
@ellnix, we've built our own version of federated search on top of |
@wesharper Wow, it must be a lot of hard to work to manually keep activerecord in sync with meilisearch. If you need help with the transition or maintenance of your current solution, and you are open source feel free to reach out. I've been curious to see examples of how teams keep ms and ar in sync in real production code, there are so many edge cases. |
@ellnix thanks so much for the offer. Unfortunately we're closed source, but happy to chat more offline. Luckily, it hasn't been too cumbersome, although we did have our search feature catastrophically fail once or twice early on. Luckily, we are able to get away with cutting some corners for various reasons, but would like to close some of the most glaring and obvious gaps now that we are going to be able to switch to this gem. |
(at)ell.nix on discord (you can also find me on the meilisearch discord's members list) The email on my commits also works. |
Depends on meilisearch-ruby 0.30 where MeiliSearch was also renamed. Used this shell command to automatically rename, and then used the git diff to manually look through and make sure nothing was wrong: find lib/ -type f -exec sed -i 's/MeiliSearch/Meilisearch/g' {} \; (of course also ran it for spec/ and playground/ after making sure the soft deprecation allowed all tests to pass). Ran into issues with the regular `const_missing` + `const_get` deprecation having issues with autoload-ed methods. Added a temporary workaround just for the Rails module. With this workaround there may be cases where users are not warned for using MeiliSearch, which should be investigated.
44542b6
to
6df283f
Compare
Rebased and resolved conflicts. |
Depends on meilisearch-ruby 0.30 where MeiliSearch was also renamed. Used this shell command to automatically rename, and then used the git diff to manually look through and make sure nothing was wrong:
(of course also ran it for spec/ and playground/ after making sure the soft deprecation allowed all tests to pass).
Ran into issues with the regular
const_missing
+const_get
deprecation having issues with autoload-ed methods. Added a temporary workaround just for the Rails module. With this workaround there may be cases where users are not warned for using MeiliSearch, which should be investigated.Pull Request
Related issue
Fixes #347