Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent background job queuing when deactivated #401

Merged
merged 2 commits into from
Mar 13, 2025

Conversation

ellnix
Copy link
Collaborator

@ellnix ellnix commented Mar 8, 2025

Pull Request

Related issue

Fixes #399

Copy link

codecov bot commented Mar 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.20%. Comparing base (6afcd40) to head (8571262).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #401   +/-   ##
=======================================
  Coverage   89.20%   89.20%           
=======================================
  Files          13       13           
  Lines         769      769           
=======================================
  Hits          686      686           
  Misses         83       83           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brunoocasali brunoocasali added the bug Something isn't working label Mar 13, 2025
@ellnix
Copy link
Collaborator Author

ellnix commented Mar 13, 2025

bors merge

@meili-bors meili-bors bot merged commit df15847 into meilisearch:main Mar 13, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabled meilisearch-rails but it still triggers the configured background jobs
2 participants